netdev - Re: [PATCH] af_key: Add lock to key dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 Apr 2017 08:39:31 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Yuejie Shi <syjcnss@...il.com>
CC:     <netdev@...r.kernel.org>, <timo.teras@....fi>,
        <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] af_key: Add lock to key dump

On Fri, Mar 31, 2017 at 03:10:20PM +0800, Yuejie Shi wrote:
> A dump may come in the middle of another dump, modifying its dump
> structure members. This race condition will result in NULL pointer
> dereference in kernel. So add a lock to prevent that race.
> 
> Fixes: 83321d6b9872 ("[AF_KEY]: Dump SA/SP entries non-atomically")
> Signed-off-by: Yuejie Shi <syjcnss@...il.com>

Applied, thanks a lot!