netdev - Re: [PATCH v2 1/3] flowcache: make flow_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 03 Apr 2017 19:05:07 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     adobriyan@...il.com
Cc:     steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/3] flowcache: make flow_key_size() return
 "unsigned int"

From: Alexey Dobriyan <adobriyan@...il.com>
Date: Mon, 3 Apr 2017 00:51:50 +0300

> Flow keys aren't 4GB+ numbers so 64-bit arithmetic is excessive.
> 
> Space savings (I'm not sure what CSWTCH is):
> 
> 	add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-48 (-48)
> 	function                                     old     new   delta
> 	flow_cache_lookup                           1163    1159      -4
> 	CSWTCH                                     75997   75953     -44
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>

Applied.