netdev - Re: [PATCH net] tcp: clear saved_syn in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 09 Apr 2017 18:28:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: clear saved_syn in tcp_disconnect()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 08 Apr 2017 08:07:33 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> In the (very unlikely) case a passive socket becomes a listener,
> we do not want to duplicate its saved SYN headers.
> 
> This would lead to double frees, use after free, and please hackers and
> various fuzzers 
> 
> Tested:
 ...
> Fixes: cd8ae85299d5 ("tcp: provide SYN headers for passive connections")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.