netdev - Re: [PATCH net-next] devlink: fix return value check in devlink_dpipe_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Apr 2017 08:39:03 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Wei Yongjun <weiyj.lk@...il.com>
Cc:     Jiri Pirko <jiri@...lanox.com>,
        Arkadi Sharshevsky <arkadis@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>,
        Wei Yongjun <weiyongjun1@...wei.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] devlink: fix return value check in
 devlink_dpipe_header_put()

Mon, Apr 10, 2017 at 03:11:06PM CEST, weiyj.lk@...il.com wrote:
>From: Wei Yongjun <weiyongjun1@...wei.com>
>
>Fix the retrn value check which testing the wrong variable

         ^^^^^ typo

Otherwise,
Acked-by: Jiri Pirko <jiri@...lanox.com>


>in devlink_dpipe_header_put().
>
>Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)")
>Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
>---
> net/core/devlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/net/core/devlink.c b/net/core/devlink.c
>index 24b7660..0afac58 100644
>--- a/net/core/devlink.c
>+++ b/net/core/devlink.c
>@@ -2031,7 +2031,7 @@ static int devlink_dpipe_header_put(struct sk_buff *skb,
> 	int err;
> 
> 	header_attr = nla_nest_start(skb, DEVLINK_ATTR_DPIPE_HEADER);
>-	if (!header)
>+	if (!header_attr)
> 		return -EMSGSIZE;
> 
> 	if (nla_put_string(skb, DEVLINK_ATTR_DPIPE_HEADER_NAME, header->name) ||
>