netdev - Re: [PATCH net-next v3 1/1] net: ipv4: Refine the ipv4_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 13 Apr 2017 13:20:20 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     gfree.wind@...mail.com
Cc:     kuznet@....inr.ac.ru, jmorris@...ei.org, netdev@...r.kernel.org,
        fgao@...ai8.com
Subject: Re: [PATCH net-next v3 1/1] net: ipv4: Refine the
 ipv4_default_advmss

From: gfree.wind@...mail.com
Date: Wed, 12 Apr 2017 12:34:03 +0800

> From: Gao Feng <fgao@...ai8.com>
> 
> 1. Don't get the metric RTAX_ADVMSS of dst.
> There are two reasons.
> 1) Its caller dst_metric_advmss has already invoke dst_metric_advmss
> before invoke default_advmss.
> 2) The ipv4_default_advmss is used to get the default mss, it should
> not try to get the metric like ip6_default_advmss.
> 
> 2. Use sizeof(tcphdr)+sizeof(iphdr) instead of literal 40.
> 
> 3. Define one new macro IPV4_MAX_PMTU instead of 65535 according to
> RFC 2675, section 5.1.
> 
> Signed-off-by: Gao Feng <fgao@...ai8.com>
> ---
>  v3: Simplify the codes again, per Joe
>  v2: Use min instead of unnecessary min_t, per Joe
>  v1: initial version

Applied, thanks.