lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Apr 2017 09:34:28 -0600 From: Logan Gunthorpe <logang@...tatee.com> To: Christoph Hellwig <hch@....de> Cc: "Martin K. Petersen" <martin.petersen@...cle.com>, Sagi Grimberg <sagi@...mberg.me>, Jens Axboe <axboe@...nel.dk>, Tejun Heo <tj@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Dan Williams <dan.j.williams@...el.com>, Ross Zwisler <ross.zwisler@...ux.intel.com>, Matthew Wilcox <mawilcox@...rosoft.com>, Sumit Semwal <sumit.semwal@...aro.org>, Ming Lin <ming.l@....samsung.com>, linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org, linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org, intel-gfx@...ts.freedesktop.org, linux-raid@...r.kernel.org, linux-mmc@...r.kernel.org, linux-nvme@...ts.infradead.org, linux-nvdimm@...ts.01.org, linux-scsi@...r.kernel.org, fcoe-devel@...n-fcoe.org, open-iscsi@...glegroups.com, megaraidlinux.pdl@...adcom.com, sparmaintainer@...sys.com, devel@...verdev.osuosl.org, target-devel@...r.kernel.org, netdev@...r.kernel.org, linux-rdma@...r.kernel.org, rds-devel@....oracle.com, Steve Wise <swise@...ngridcomputing.com>, Stephen Bates <sbates@...thlin.com> Subject: Re: [PATCH 01/22] scatterlist: Introduce sg_map helper functions On 14/04/17 02:35 AM, Christoph Hellwig wrote: >> + >> static inline int is_dma_buf_file(struct file *); >> >> struct dma_buf_list { > > I think the right fix here is to rename the operation to unmap_atomic > and send out a little patch for that ASAP. Ok, I can do that next week. > I'd rather have separate functions for kmap vs kmap_atomic instead of > the flags parameter. And while you're at it just always pass the 0 > offset parameter instead of adding a wrapper.. > > Otherwise this looks good to me. I settled on the flags because I thought the interface could be expanded to do more things like automatically copy iomem to a bounce buffer (with a flag). It'd also be possible to add things like vmap and physical_address to the interface which would cover even more sg_page users. All the implementations would then share the common offset calculations, and switching between them becomes a matter of changing a couple flags. If you're still not convinced by the above arguments then I'll change it but I did have reasons for choosing to do it this way. I am fine with removing the offset versions. I will make that change. Thanks, Logan
Powered by blists - more mailing lists