netdev - Re: [PATCH] net: tc35815: move free after the dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Apr 2017 12:38:29 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     anemo@....ocn.ne.jp, tremyfr@...il.com, jarod@...hat.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net: tc35815: move free after the dereference

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Fri, 21 Apr 2017 13:49:37 +0300

> We dereference "skb" to get "skb->len" so we should probably do that
> step before freeing the skb.
> 
> Fixes: eea221ce4880 ("tc35815 driver update (take 2)")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied, thanks Dan.