netdev - Re: [PATCH] net: dsa: mv88e6xxx: fix mdio bus name when using devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 May 2017 17:20:54 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Sylvain Lemieux <slemieux.tyco@...il.com>
Cc:     vivien.didelot@...oirfairelinux.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix mdio bus name when using
 devicetree

On Mon, May 01, 2017 at 10:54:04AM -0400, Sylvain Lemieux wrote:
> From: Liam Beguin <lbeguin@...oint.com>
> 
> mv88e6xxx_mdio_register automatically generates mdio buses for each switch
> discovered in the devicetree. When switch nodes are embedded in other nodes,
> this can cause sysfs naming collisions since full_name may be truncated.
> 
> Only use devicetree node name instead of the full devicetree path
> as the mdio bus name.

Hi Sylvain

I'm not sure this is a good idea. It probably breaks my boards:

:/sys/class/mdio_bus# ls
!mdio-mux!mdio@...witch@...dio	0.1  0.4  400d0000.ethernet-1  fixed-0
!mdio-mux!mdio@...witch@...dio	0.2  0.8  400d1000.ethernet-2  mv88e6xxx-0

np->name is not unique, where as np->full_name is unique.

However, i can understand your problem with truncation. Maybe a better
solution is to detect if truncation is going to happen. If so, use a
concatenation of a hash of np->full_name, and the right hand part of
np->full_name?

	Andrew