[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 5 May 2017 12:50:31 +0300
From: Amir Goldstein <amir73il@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Dan Williams <dan.j.williams@...el.com>,
Linux ACPI <linux-acpi@...r.kernel.org>,
tpmdd-devel@...ts.sourceforge.net, intel-gfx@...ts.freedesktop.org,
nouveau@...ts.freedesktop.org, linux-input@...r.kernel.org,
iommu@...ts.linux-foundation.org, linux-mmc@...r.kernel.org,
Netdev <netdev@...r.kernel.org>, linux-pci@...r.kernel.org,
USB list <linux-usb@...r.kernel.org>,
alsa-devel@...a-project.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Rafael J . Wysocki" <rjw@...ysocki.net>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Borislav Petkov <bp@...e.de>,
Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
Jani Nikula <jani.nikula@...ux.intel.com>,
Ben Skeggs <bskeggs@...hat.com>,
Benjamin Tissoires <benjamin.tissoires@...hat.com>,
Joerg Roedel <joro@...tes.org>,
Adrian Hunter <adrian.hunter@...el.com>,
Yisen Zhuang <yisen.zhuang@...wei.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Zhang Rui <rui.zhang@...el.com>,
Felipe Balbi <balbi@...nel.org>,
Mathias Nyman <mathias.nyman@...el.com>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v1] ACPI: Switch to use generic UUID API
On Fri, May 5, 2017 at 12:24 PM, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> On Fri, 2017-05-05 at 10:06 +0300, Amir Goldstein wrote:
[...]
>> I think with this semantic change, our proposals can reach common
>> grounds
>> and satisfy a wider group of users (i.e. filesystem developers).
>>
>> Christoph also suggested a similar treatment to typedef guid_t to
>> struct uuid_le.
>> I don't know the use cases enough to comment on that.
>
> We may go this way. But I wouldn't prevent current users of uuid_le to
> continue using it without conversion (it may be done case by case after
> we settle an API)
>
> So, summarize what Christoph said it will look like
>
> typedef uuid_be uuid_t;
> typedef uuid_le guid_t
>
> uuid_cmp() / uuid_copy() / uuid_to_bin() / etc
> guid_cmp() / guid_copy() / guid_to_bin() / etc
>
> Correct? Christoph?
>
That looks right to me.
To complete the picture for folks not cc'ed on my patches,
xfs use case suggests there is also justification for the additional helpers:
uuid_is_null() / uuid_equal()
guid_is_null() / guid_equal()
Cheers,
Amir.
Powered by blists - more mailing lists