netdev - Re: [PATCH net] net: fix compile error in skb_orphan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 17 May 2017 15:11:20 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     paul.gortmaker@...driver.com, rdunlap@...radead.org,
        sfr@...b.auug.org.au, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: fix compile error in skb_orphan_partial()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 16 May 2017 13:27:53 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> If CONFIG_INET is not set, net/core/sock.c can not compile :
> 
> net/core/sock.c: In function ‘skb_orphan_partial’:
> net/core/sock.c:1810:2: error: implicit declaration of function
> ‘skb_is_tcp_pure_ack’ [-Werror=implicit-function-declaration]
>   if (skb_is_tcp_pure_ack(skb))
>   ^
> 
> Fix this by always including <net/tcp.h>
> 
> Fixes: f6ba8d33cfbb ("netem: fix skb_orphan_partial()")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>

Applied and queued up for -stable, thanks Eric.