netdev - Re: [PATCH v4] bridge: netlink: check vlan_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 May 2017 10:15:23 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tobias.jungel@...dn.de
Cc:     sd@...asysnail.net, nikolay@...ulusnetworks.com,
        stephen@...workplumber.org, netdev@...r.kernel.org
Subject: Re: [PATCH v4] bridge: netlink: check vlan_default_pvid range

From: Tobias Jungel <tobias.jungel@...dn.de>
Date: Wed, 17 May 2017 09:29:12 +0200

> Currently it is allowed to set the default pvid of a bridge to a value
> above VLAN_VID_MASK (0xfff). This patch adds a check to br_validate and
> returns -EINVAL in case the pvid is out of bounds.
> 
> Reproduce by calling:
> 
> [root@...t ~]# ip l a type bridge
> [root@...t ~]# ip l a type dummy
> [root@...t ~]# ip l s bridge0 type bridge vlan_filtering 1
> [root@...t ~]# ip l s bridge0 type bridge vlan_default_pvid 9999
> [root@...t ~]# ip l s dummy0 master bridge0
> [root@...t ~]# bridge vlan
> port	vlan ids
> bridge0	 9999 PVID Egress Untagged
> 
> dummy0	 9999 PVID Egress Untagged
> 
> Fixes: 0f963b7592ef ("bridge: netlink: add support for default_pvid")
> Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> Signed-off-by: Tobias Jungel <tobias.jungel@...dn.de>

Applied and queued up for -stable, thank you.