netdev - Re: [PATCH net-next v2] bridge: fix hello and hold timers starting/stopping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 May 2017 14:41:30 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     cera@...a.cz
Cc:     netdev@...r.kernel.org, sashok@...ulusnetworks.com,
        stephen@...workplumber.org, bridge@...ts.linux-foundation.org,
        lucien.xin@...il.com, nikolay@...ulusnetworks.com
Subject: Re: [PATCH net-next v2] bridge: fix hello and hold timers
 starting/stopping

From: Ivan Vecera <cera@...a.cz>
Date: Fri, 19 May 2017 19:30:43 +0200

> Current bridge code incorrectly handles starting/stopping of hello and
> hold timers during STP enable/disable.
> 
> 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP
>    transition. The timers are already stopped in NO_STP state so
>    this is confusing no-op.
> 
> 2. During USER_STP->NO_STP transition the timers are started. This
>    does not make sense and is confusion because the timer should not be
>    active in NO_STP state.
> 
> Cc: davem@...emloft.net
> Cc: sashok@...ulusnetworks.com
> Cc: stephen@...workplumber.org
> Cc: bridge@...ts.linux-foundation.org
> Cc: lucien.xin@...il.com
> Cc: nikolay@...ulusnetworks.com
> Signed-off-by: Ivan Vecera <cera@...a.cz>

Applied.