netdev - Re: arch: arm: bpf: Converting cBPF to eBPF for arm 32 bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 May 2017 15:01:16 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Shubham Bansal <illusionist.neo@...il.com>
CC:     Kees Cook <keescook@...omium.org>,
        David Miller <davem@...emloft.net>,
        Mircea Gherzan <mgherzan@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        "kernel-hardening@...ts.openwall.com" 
        <kernel-hardening@...ts.openwall.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>, ast@...com
Subject: Re: arch: arm: bpf: Converting cBPF to eBPF for arm 32 bit

On 05/20/2017 10:01 PM, Shubham Bansal wrote:
[...]
> Before I send the patch, I have tested the JIT compiler on ARMv7 but
> not on ARMv5 or ARMv6. So can you tell me which arch versions I should
> test it for?
> Also for my testing, CONFIG_FRAME_POINTER and CONFIG_CPU_BIG_ENDIAN
> are both disabled. But I need to test JIT with these flags as well.
> Whenever I put these flags in .config file, the arm kernel is not
> getting compiler with these flags. Can you tell me why? If you need
> more information regarding this, please let me know.

Maybe Mircea, Kees or someone from linux-arm-kernel can help you out
on that.

With regards to the below benchmark, I was mentioning how it compares
to the interpreter. With only the numbers for jit it's hard to compare.
So would be great to see the output for the following three cases:

1) Interpreter:

echo 0 > /proc/sys/net/core/bpf_jit_enable

2) JIT enabled:

echo 1 > /proc/sys/net/core/bpf_jit_enable

3) JIT + blinding enabled:

echo 1 > /proc/sys/net/core/bpf_jit_enable
echo 2 > /proc/sys/net/core/bpf_jit_harden

> With current config for ARMv7, benchmarks are :
>
> [root@...press modules]# insmod test_bpf.ko
> [   25.797766] test_bpf: #0 TAX jited:1 180 170 169 PASS
> [   25.811395] test_bpf: #1 TXA jited:1 93 89 111 PASS
> [   25.815073] test_bpf: #2 ADD_SUB_MUL_K jited:1 94 PASS
> [   25.816779] test_bpf: #3 DIV_MOD_KX jited:1 983 PASS
> [   25.827310] test_bpf: #4 AND_OR_LSH_K jited:1 94 93 PASS
> [   25.829843] test_bpf: #5 LD_IMM_0 jited:1 83 PASS
> [   25.831260] test_bpf: #6 LD_IND jited:1 338 266 305 PASS
[...]

Thanks,
Daniel