netdev - Re: [PATCH V6 net-next iproute] ip: Add support for netdev events to monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 May 2017 10:12:21 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Vladislav Yasevich <vyasevich@...il.com>
Cc:     netdev@...r.kernel.org, dsahern@...il.com,
        roopa@...ulusnetworks.com, jiri@...nulli.us, vfalico@...il.com,
        andy@...yhouse.net, Vladislav Yasevich <vyasevic@...hat.com>
Subject: Re: [PATCH V6 net-next iproute] ip: Add support for netdev events
 to monitor

On Sat, 27 May 2017 10:14:36 -0400
Vladislav Yasevich <vyasevich@...il.com> wrote:

>  
> +static const char *netdev_events[] = {"NONE",
> +				      "REBOOT",
> +				      "FEATURE CHANGE",
> +				      "BONDING FAILOVER",
> +				      "NOTIFY PEERS",
> +				      "RESEND IGMP",
> +				      "BONDING OPTION"};

Overall this looks fine, I will pickup the if_link.h from net-next.

One stylistic change.

Please add simple line break, and initialize by value:

static const char *netdev_events[] = {
	[IFLA_EVENT_NONE]	= "NONE",
...

Do you want some prefix or bounding around the event output?
Also a little concerned that the output format change may break some program
could the new output be at the end of the line?