netdev - Re: [PATCH net] net/mlx5: avoid build warning for uniprocessor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 30 May 2017 14:09:38 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     saeedm@...lanox.com, matanb@...lanox.com, leonro@...lanox.com,
        mohamad@...lanox.com, danielj@...lanox.com, eli@...lanox.com,
        avivh@...lanox.com, huyn@...lanox.com, artemyko@...lanox.com,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net/mlx5: avoid build warning for uniprocessor

From: Arnd Bergmann <arnd@...db.de>
Date: Mon, 29 May 2017 15:00:17 +0200

> Building the driver with CONFIG_SMP disabled results in a harmless
> warning:
> 
> ethernet/mellanox/mlx5/core/main.c: In function 'mlx5_irq_set_affinity_hint':
> ethernet/mellanox/mlx5/core/main.c:615:6: error: unused variable 'irq' [-Werror=unused-variable]
> 
> It's better to express the conditional compilation using IS_ENABLED()
> here, as that lets the compiler see what the intented use for the variable
> is, and that it can be silently discarded.
> 
> Fixes: b665d98edc9a ("net/mlx5: Tolerate irq_set_affinity_hint() failures")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thank you.