netdev - Re: [PATCH net-next 4/8] bpf: Add BPF_PROG_GET_FD_BY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 May 2017 11:21:09 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Martin KaFai Lau <kafai@...com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>, kernel-team@...com
Subject: Re: [PATCH net-next 4/8] bpf: Add BPF_PROG_GET_FD_BY_ID

Hi Martin,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Martin-KaFai-Lau/bpf-Introduce-bpf_prog-ID/20170531-110650
config: x86_64-randconfig-x015-201722 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from arch/x86/include/asm/bug.h:81:0,
                    from include/linux/bug.h:4,
                    from include/linux/thread_info.h:11,
                    from arch/x86/include/asm/preempt.h:6,
                    from include/linux/preempt.h:80,
                    from include/linux/spinlock.h:50,
                    from include/linux/seqlock.h:35,
                    from include/linux/time.h:5,
                    from include/linux/ktime.h:24,
                    from include/linux/timer.h:5,
                    from include/linux/workqueue.h:8,
                    from include/linux/bpf.h:12,
                    from kernel/bpf/syscall.c:12:
   kernel/bpf/syscall.c: In function 'bpf_prog_inc_not_zero':
>> kernel/bpf/syscall.c:834:16: error: implicit declaration of function 'lockdep_is_held' [-Werror=implicit-function-declaration]
     WARN_ON_ONCE(!lockdep_is_held(&prog_idr_lock));
                   ^
   include/asm-generic/bug.h:65:25: note: in definition of macro 'WARN_ON_ONCE'
     int __ret_warn_on = !!(condition);   \
                            ^~~~~~~~~
   cc1: some warnings being treated as errors

vim +/lockdep_is_held +834 kernel/bpf/syscall.c

   828	EXPORT_SYMBOL_GPL(bpf_prog_inc);
   829	
   830	static struct bpf_prog *bpf_prog_inc_not_zero(struct bpf_prog *prog)
   831	{
   832		int refold;
   833	
 > 834		WARN_ON_ONCE(!lockdep_is_held(&prog_idr_lock));
   835		refold = __atomic_add_unless(&prog->aux->refcnt, 1, 0);
   836	
   837		if (refold >= BPF_MAX_REFCNT) {

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28833 bytes)