netdev - [PATCH] net: pch_gbe: fix err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Jun 2017 14:36:42 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Paul Burton <paul.burton@...tec.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        Tobias Klauser <tklauser@...tanz.ch>,
        "David S . Miller" <davem@...emloft.net>,
        Jarod Wilson <jarod@...hat.com>, linux-mips@...ux-mips.org,
        Eric Dumazet <edumazet@...gle.com>,
        Paul Burton <paul.burton@...tec.com>
Subject: [PATCH] net: pch_gbe: fix err_cast.cocci warnings

drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2587:9-16: WARNING: ERR_CAST can be used with gpio


 Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))

Generated by: scripts/coccinelle/api/err_cast.cocci

CC: Paul Burton <paul.burton@...tec.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

 pch_gbe_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -2584,7 +2584,7 @@ pch_gbe_get_priv(struct pci_dev *pdev, c
 	if (!IS_ERR(gpio))
 		pdata->phy_reset_gpio = gpio;
 	else if (PTR_ERR(gpio) != -ENOENT)
-		return ERR_PTR(PTR_ERR(gpio));
+		return ERR_CAST(gpio);
 
 	return pdata;
 }