netdev - Re: [PATCH] net/phy: Delete unused function phy_ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 4 Jun 2017 10:20:59 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Yuval Shaia <yuval.shaia@...cle.com>, andrew@...n.ch,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net/phy: Delete unused function phy_ethtool_gset



On 06/04/2017 10:10 AM, Yuval Shaia wrote:
> Signed-off-by: Yuval Shaia <yuval.shaia@...cle.com>

A commit message that just says: it's unused, so remove it would be
nice. You seem to have missed Documentation/networking/phy.txt in this
patch, do you mind resubmitting with that fixed?

Finally, the subject should be:

net: phy: Delete unused function phy_ethtool_gset

to be (semi) consistent with past submissions done to these files. Thanks!

> ---
>  drivers/net/phy/phy.c | 24 ------------------------
>  include/linux/phy.h   |  1 -
>  2 files changed, 25 deletions(-)
> 
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 9c372bf..8e26af5 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -484,30 +484,6 @@ int phy_ethtool_ksettings_set(struct phy_device *phydev,
>  }
>  EXPORT_SYMBOL(phy_ethtool_ksettings_set);
>  
> -int phy_ethtool_gset(struct phy_device *phydev, struct ethtool_cmd *cmd)
> -{
> -	cmd->supported = phydev->supported;
> -
> -	cmd->advertising = phydev->advertising;
> -	cmd->lp_advertising = phydev->lp_advertising;
> -
> -	ethtool_cmd_speed_set(cmd, phydev->speed);
> -	cmd->duplex = phydev->duplex;
> -	if (phydev->interface == PHY_INTERFACE_MODE_MOCA)
> -		cmd->port = PORT_BNC;
> -	else
> -		cmd->port = PORT_MII;
> -	cmd->phy_address = phydev->mdio.addr;
> -	cmd->transceiver = phy_is_internal(phydev) ?
> -		XCVR_INTERNAL : XCVR_EXTERNAL;
> -	cmd->autoneg = phydev->autoneg;
> -	cmd->eth_tp_mdix_ctrl = phydev->mdix_ctrl;
> -	cmd->eth_tp_mdix = phydev->mdix;
> -
> -	return 0;
> -}
> -EXPORT_SYMBOL(phy_ethtool_gset);
> -
>  void phy_ethtool_ksettings_get(struct phy_device *phydev,
>  			       struct ethtool_link_ksettings *cmd)
>  {
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 4ec07a6..804851c 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -843,7 +843,6 @@ void phy_start_machine(struct phy_device *phydev);
>  void phy_stop_machine(struct phy_device *phydev);
>  void phy_trigger_machine(struct phy_device *phydev, bool sync);
>  int phy_ethtool_sset(struct phy_device *phydev, struct ethtool_cmd *cmd);
> -int phy_ethtool_gset(struct phy_device *phydev, struct ethtool_cmd *cmd);
>  void phy_ethtool_ksettings_get(struct phy_device *phydev,
>  			       struct ethtool_link_ksettings *cmd);
>  int phy_ethtool_ksettings_set(struct phy_device *phydev,
> 

-- 
Florian