netdev - Re: [PATCH][-next] mwifiex: make function mwifiex_ret_pkt_aggr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Jun 2017 08:23:13 +0000
From:   Xinming Hu <huxm@...vell.com>
To:     Colin King <colin.king@...onical.com>,
        Amitkumar Karwar <amitkarwar@...il.com>,
        Nishant Sarmukadam <nishants@...vell.com>,
        "Ganapathi Bhat" <gbhat@...vell.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Cathy Luo <cluo@...vell.com>
Subject: Re:  [PATCH][-next] mwifiex: make function mwifiex_ret_pkt_aggr_ctrl
 static

Hi Colin,

> -----Original Message-----
> From: Colin King [mailto:colin.king@...onical.com]
> Sent: 2017年6月2日 16:57
> To: Amitkumar Karwar; Nishant Sarmukadam; Ganapathi Bhat; Xinming Hu;
> Kalle Valo; linux-wireless@...r.kernel.org; netdev@...r.kernel.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [EXT] [PATCH][-next] mwifiex: make function
> mwifiex_ret_pkt_aggr_ctrl static
> 
> External Email
> 
> ----------------------------------------------------------------------
> From: Colin Ian King <colin.king@...onical.com>
> 
> function mwifiex_ret_pkt_aggr_ctrl can be made static as it does not need to
> be in global scope.
> 
> Cleans up sparse warning: "symbol 'mwifiex_ret_pkt_aggr_ctrl' was not
> declared. Should it be static?"

Yes, it should be static, Thanks,

Regards,
Simon
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c
> b/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c
> index 3348fb3a7514..2945775e83c5 100644
> --- a/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c
> +++ b/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c
> @@ -1154,8 +1154,8 @@ static int mwifiex_ret_chan_region_cfg(struct
> mwifiex_private *priv,
>  	return 0;
>  }
> 
> -int mwifiex_ret_pkt_aggr_ctrl(struct mwifiex_private *priv,
> -			      struct host_cmd_ds_command *resp)
> +static int mwifiex_ret_pkt_aggr_ctrl(struct mwifiex_private *priv,
> +				     struct host_cmd_ds_command *resp)
>  {
>  	struct host_cmd_ds_pkt_aggr_ctrl *pkt_aggr_ctrl =
>  					&resp->params.pkt_aggr_ctrl;
> --
> 2.11.0