netdev - Re: [PATCH net 3/3] netvsc: fix RCU warning from set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 06 Jun 2017 15:55:35 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     stephen@...workplumber.org
Cc:     netdev@...r.kernel.org, sthemmin@...rosoft.com
Subject: Re: [PATCH net 3/3] netvsc: fix RCU warning from set_multicast

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Mon,  5 Jun 2017 14:10:10 -0700

> +	nvdev = rtnl_dereference(ndevctx->nvdev);
> +	if (nvdev)
> +		rdev = nvdev->extension;
> +
> +		if (rdev) {
> +			if (ndev->flags & IFF_PROMISC)
> +				rndis_filter_set_packet_filter(rdev,
> +							       NDIS_PACKET_TYPE_PROMISCUOUS);
> +			else
> +				rndis_filter_set_packet_filter(rdev,
> +							       NDIS_PACKET_TYPE_BROADCAST |
> +							       NDIS_PACKET_TYPE_ALL_MULTICAST |
> +							       NDIS_PACKET_TYPE_DIRECTED);
> +		}
> +	}

Stephen, please at least compile test your code.

This is getting rediculous.