netdev - Re: [PATCH] cxgb4: implement ndo_set_vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2017 12:13:03 +0530
From:   Ganesh Goudar <ganeshgr@...lsio.com>
To:     "Mintz, Yuval" <Yuval.Mintz@...ium.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "nirranjan@...lsio.com" <nirranjan@...lsio.com>,
        "kumaras@...lsio.com" <kumaras@...lsio.com>
Subject: Re: [PATCH] cxgb4: implement ndo_set_vf_rate()

On Monday, June 06/05/17, 2017 at 14:03:14 +0000, Mintz, Yuval wrote:
> > +	pktsize = be16_to_cpu(port_rpl.u.info.mtu);
> > +	/* subtract ethhdr size and 4 bytes crc since, f/w appends it */
> > +	pktsize = pktsize - sizeof(struct ethhdr) - 4;
> > +	/* subtract ipv4 hdr size, tcp hdr size to get typical IPv4 MSS size */
> > +	pktsize = pktsize - sizeof(struct iphdr) - sizeof(struct tcphdr);
> > +	/* configure Traffic Class for rate-limiting */
> > +	ret = t4_sched_params(adap, SCHED_CLASS_TYPE_PACKET,
> > +			      SCHED_CLASS_LEVEL_CL_RL,
> > +			      SCHED_CLASS_MODE_CLASS,
> > +			      SCHED_CLASS_RATEUNIT_BITS,
> > +			      SCHED_CLASS_RATEMODE_ABS,
> > +			      pi->port_id, class_id, 0,
> > +			      max_tx_rate * 1000, 0, pktsize);
> 
> Does it mean you're achieving throughput limitation by
> limiting the PP/s?
By bits/sec.