netdev - Re: [PATCH v2] xfrm: fix xfrm_dev_event() missing when compile without CONFIG_XFRM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2017 17:26:01 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Steffen Klassert <steffen.klassert@...unet.com>
Cc:     netdev@...r.kernel.org, Guy Shapiro <guysh@...lanox.com>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH v2] xfrm: fix xfrm_dev_event() missing when compile
 without CONFIG_XFRM_OFFLOAD

On Tue, Jun 06, 2017 at 10:06:58AM +0200, Steffen Klassert wrote:
> On Thu, Jun 01, 2017 at 02:57:56PM +0800, Hangbin Liu wrote:
> > In commit d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API") we
> > make xfrm_device.o only compiled when enable option CONFIG_XFRM_OFFLOAD.
> > But this will make xfrm_dev_event() missing if we only enable default XFRM
> > options.
> > 
> > Then if we set down and unregister an interface with IPsec on it.
> 
> You should not be able to register an interface with IPsec offload
> without CONFIG_XFRM_OFFLOAD.

Yes, I mean when compile with default CONFIG_XFRM, the xfrm_dev_event() ->
xfrm_dev_down() -> xfrm_garbage_collect() will missing.

> 
> > there
> > will no xfrm_garbage_collect(), which will cause dev usage count hold and
> > get error like:
> > 
> > unregister_netdevice: waiting for <dev> to become free. Usage count = 4
> 
> Can you explain how to reproduce this?
> 

Sure, I didn't try physical drivers, just test latest net-next with
bridge/bonding and could reproduce it everytime.

```
# cat rep.sh
#!/bin/bash
iface=$1
src=$2
dst=$3
run=$4

brctl addbr br0
brctl addif br0 ${iface}
ip link set ${iface} up
ip link set br0 up
ip addr add ${src}/24 dev br0
ip xfrm state flush && ip xfrm policy flush
ip xfrm state add src ${src} dst ${dst} spi 1000 proto esp enc des3_ede _I_want_to_have_chicken_ auth sha1 beef_fish_pork_salad mode transport
ip xfrm state add src ${dst} dst ${src} spi 1000 proto esp enc des3_ede _I_want_to_have_chicken_ auth sha1 beef_fish_pork_salad mode transport
ip xfrm policy add src ${src} dst ${dst} dir out tmpl proto esp spi 1000 mode transport
ip xfrm policy add src ${dst} dst ${src} dir in tmpl proto esp spi 1000 mode transport

if [ "$run" ]; then
        sleep 1
        ping ${dst} -c 4
        ip link set br0 down
        ip link del br0
fi
```

On host A run : # ./rep.sh eth1 192.168.1.1 192.168.1.2
On host B run : # ./rep.sh eth1 192.168.1.2 192.168.1.1 run

Then we will see error like
kernel:unregister_netdevice: waiting for br0 to become free. Usage count = 3

Thanks
Hangbin