lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Jun 2017 17:51:06 +0800 From: 严海双 <yanhaishuang@...s.chinamobile.com> To: "David S. Miller" <davem@...emloft.net>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Patrick McHardy <kaber@...sh.net>, zhangshengju <zhangshengju@...s.chinamobile.com> Cc: Linux Kernel Network Developers <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Alexei Starovoitov <ast@...com> Subject: Re: [PATCH] ip6_tunnel: fix potential issue in __ip6_tnl_rcv > On 13 Jun 2017, at 4:56 PM, Haishuang Yan <yanhaishuang@...s.chinamobile.com> wrote: > > When __ip6_tnl_rcv fails, the tun_dst won't be freed, so call > dst_release to free it in error code path. > > CC: Alexei Starovoitov <ast@...com> > Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") > Signed-off-by: Haishuang Yan <yanhaishuang@...s.chinamobile.com> > Tested-by: Zhang Shengju <zhangshengju@...s.chinamobile.com> > > --- > v4: > - Add tester information > v3: > - Free tun_dst from error code path > v2: > - Add the the missing Fixes information > --- > net/ipv6/ip6_tunnel.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c > index 9b37f97..ef99d59 100644 > --- a/net/ipv6/ip6_tunnel.c > +++ b/net/ipv6/ip6_tunnel.c > @@ -859,6 +859,8 @@ static int __ip6_tnl_rcv(struct ip6_tnl *tunnel, struct sk_buff *skb, > return 0; > > drop: > + if (tun_dst) > + dst_release((struct dst_entry *)tun_dst); > kfree_skb(skb); > return 0; > } > -- > 1.8.3.1 > > Hi David, Please ignore the patches, I forgot to add subject prefix, sorry.
Powered by blists - more mailing lists