netdev - Re: [PATCH net-next] selftests/bpf: make correct use of exit codes in bpf selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Jun 2017 21:35:40 +0800
From:   Fengguang Wu <fengguang.wu@...el.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     netdev@...r.kernel.org, Daniel Borkmann <borkmann@...earbox.net>,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests/bpf: make correct use of exit codes
 in bpf selftests

On Tue, Jun 13, 2017 at 03:17:19PM +0200, Jesper Dangaard Brouer wrote:
>The selftests depend on using the shell exit code as a mean of
>detecting the success or failure of test-binary executed.  The
>appropiate output "[PASS]" or "[FAIL]" in generated by
>tools/testing/selftests/lib.mk.
>
>Notice that the exit code is masked with 255. Thus, be careful if
>using the number of errors as the exits code, as 256 errors would be

nit pick:

s/exits/exit/

> 	printf("Summary: %d PASSED, %d FAILED\n", passes, errors);
>-	return errors ? -errors : 0;
>+	return errors ? EXIT_FAILURE : EXIT_SUCCESS;

Reviewed-by: Fengguang Wu <fengguang.wu@...el.com>

Thanks,
Fengguang