netdev - Re: [PATCH iproute/master 2/3] iptunnel: add support for mpls/ip to sit tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Jun 2017 10:02:11 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Krister Johansen <kjlx@...pleofstupid.com>
Cc:     netdev@...r.kernel.org, simon.horman@...ronome.com,
        dsahern@...il.com
Subject: Re: [PATCH iproute/master 2/3] iptunnel: add support for mpls/ip to
 sit tunnels

On Fri,  9 Jun 2017 18:31:31 -0700
Krister Johansen <kjlx@...pleofstupid.com> wrote:

> diff --git a/include/utils.h b/include/utils.h
> index bfbc9e6..60ffde4 100644
> --- a/include/utils.h
> +++ b/include/utils.h
> @@ -87,6 +87,9 @@ struct ipx_addr {
>  #ifndef AF_MPLS
>  # define AF_MPLS 28
>  #endif
> +#ifndef IPPROTO_MPLS
> +#define IPPROTO_MPLS	137
> +#endif
>  

I am a little concerned that this definition may end up being different
between kernel and iproute2.  It looks like utils.h already has lots of duplicate
definitions of things that are in standard include directory.

Most of these like IPSEC and DECNET are old, but MPLS might get changed
in the process of going into glibc.

Is there anyway to get this from the kernel headers which are cloned
into include/linux/ already?