netdev - Re: [PATCH net-next] net: use skb_unref() in napi_consume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Jun 2017 15:24:39 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, brouer@...hat.com, edumazet@...gle.com
Subject: Re: [PATCH net-next] net: use skb_unref() in napi_consume_skb()

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed, 14 Jun 2017 11:48:48 +0200

> The commit 83ada39bb79d ("net: factor out a helper to decrement the
> skb refcount") provided and used a helper for decrementing skb usage,
> but I missed at least a spot for it.
> 
> This change remove some more duplicated code reusing skb_unref() in
> napi_consume_skb(), too. The helper uses an additional, unneeded
> unlikely(!skb) test - napi_consume_skb() already check it a few lines
> above - but the compiler is smart enough to optimize the duplicated
> test out.
> 
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied.