netdev - RE: [PATCH net-next 00/11] skb_put_zero() used to optimize code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Jun 2017 23:45:02 +0000
From:   YUAN Linyu <Linyu.Yuan@...atel-sbell.com.cn>
To:     Johannes Berg <johannes@...solutions.net>,
        "cugyly@....com" <cugyly@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "David S . Miller" <davem@...emloft.net>
Subject: RE: [PATCH net-next 00/11] skb_put_zero() used to optimize code



> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of Johannes Berg
> Sent: Thursday, June 15, 2017 12:32 AM
> To: cugyly@....com; netdev@...r.kernel.org
> Cc: David S . Miller; YUAN Linyu
> Subject: Re: [PATCH net-next 00/11] skb_put_zero() used to optimize code
> 
> On Wed, 2017-06-14 at 18:29 +0200, Johannes Berg wrote:
> > On Wed, 2017-06-14 at 23:00 +0800, yuan linyu wrote:
> >
> > > sorry, I do them by hand.
> >
> > oh, ok.
> >
> > This seems to work:
> >
> > @@
> > identifier p;
> > expression len;
> > expression skb;
> > type t;
> > @@
> > -p = (t)skb_put(skb, len);
> > -memset(p, 0, len);
> > +p = (t)skb_put_zero(skb, len);
> 
> Nope, still didn't find everything - not the batman and atm cases for
> example. But still a few more, I think that you didn't find, e.g. in
> mac80211.
Yes, I thought you already done in mac80211
> 
> Anyway - I think none of this is really critical.
> 
> johannes