netdev - Re: [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device definitions to UAPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Jun 2017 07:28:27 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     "Tung, Chien Tin" <chien.tin.tung@...el.com>
Cc:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        Doug Ledford <dledford@...hat.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Steve Wise <swise@...ngridcomputing.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Ariel Almog <ariela@...lanox.com>,
        Linux Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device
 definitions to UAPI

On Wed, Jun 21, 2017 at 04:18:54PM +0000, Tung, Chien Tin wrote:
> > From: Jason Gunthorpe [mailto:jgunthorpe@...idianresearch.com]
> > Sent: Wednesday, June 21, 2017 11:12 AM
> > To: Leon Romanovsky <leon@...nel.org>
> > Cc: Doug Ledford <dledford@...hat.com>; linux-rdma@...r.kernel.org; Tung,
> > Chien Tin <chien.tin.tung@...el.com>; Steve Wise
> > <swise@...ngridcomputing.com>; Stephen Hemminger
> > <stephen@...workplumber.org>; Jiri Pirko <jiri@...lanox.com>; Ariel Almog
> > <ariela@...lanox.com>; Linux Netdev <netdev@...r.kernel.org>; Leon
> > Romanovsky <leonro@...lanox.com>
> > Subject: Re: [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device
> > definitions to UAPI
> >
> > On Wed, Jun 21, 2017 at 09:05:22AM +0300, Leon Romanovsky wrote:
> > >  	RDMA_NL_IWCM,
> > >  	RDMA_NL_RSVD,
> > >  	RDMA_NL_LS,	/* RDMA Local Services */
> > > +	/*
> > > +	 * RDMA_NL_I40IW not in use and it was added here by mistake,
> > > +	 * but we need to keep it anyway, because it is UAPI and for
> > > +	 * unknown reasons, someone in the field decided to replace "5"
> > > +	 * with this define.
> > > +	 */
> > >  	RDMA_NL_I40IW,
> >
> > Since this doesn't do anything, never did anything, I think you should just
> > delete it. Anything in userspace that refers to this name is unconditionally
> > broken and a compile failure is the better choice.
> >
> > Jason
>
> I agree.  Please delete RDMA_NL_I40IW.

Fixed and Steve's comments too.

Thanks

>
> Chien

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)