lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 24 Jun 2017 11:40:52 +0800 From: Yunsheng Lin <linyunsheng@...wei.com> To: Andrew Lunn <andrew@...n.ch> CC: <davem@...emloft.net>, <f.fainelli@...il.com>, <huangdaode@...ilicon.com>, <xuwei5@...ilicon.com>, <liguozhu@...ilicon.com>, <Yisen.Zhuang@...wei.com>, <gabriele.paoloni@...wei.com>, <john.garry@...wei.com>, <linuxarm@...wei.com>, <salil.mehta@...wei.com>, <lipeng321@...wei.com>, <tremyfr@...il.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH NET v3 1/2] net: phy: Add phy loopback support in net phy framework Hi, Andrew On 2017/6/24 11:12, Andrew Lunn wrote: >> +int phy_loopback(struct phy_device *phydev, bool enable) >> +{ >> + struct phy_driver *phydrv = to_phy_driver(phydev->mdio.dev.driver); >> + int ret = 0; >> + >> + if (enable && phydev->loopback_enabled) >> + return -EBUSY; >> + >> + if (!enable && !phydev->loopback_enabled) >> + return -EINVAL; >> + >> + if (phydev->drv && phydrv->set_loopback) >> + ret = phydrv->set_loopback(phydev, enable); > > else > ret = -EOPNOTSUPP; > >> + >> + if (ret) >> + return ret; >> + >> + phydev->loopback_enabled = enable; >> + >> + return 0; >> +} >> +EXPORT_SYMBOL(phy_loopback); > > One of the comments we made of the PHY code in the hns driver is that > its locking is completely broken. You have made the same error > here. The core needs to hold the mutex while calling into the PHY > driver. Do you mean hns_nic_config_phy_loopback need to hold the mutex while calling phy_loopback? and other place that calling phy_* function? Best Regards Yunsheng Lin
Powered by blists - more mailing lists