netdev - Re: [PATCH net-next v2 8/9] nfp: add a stats handler for flower offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Jun 2017 16:53:54 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     Or Gerlitz <gerlitz.or@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        oss-drivers@...ronome.com,
        Pieter Jansen van Vuuren 
        <pieter.jansenvanvuuren@...ronome.com>
Subject: Re: [PATCH net-next v2 8/9] nfp: add a stats handler for flower
 offloads

On Thu, Jun 29, 2017 at 05:39:34PM +0300, Or Gerlitz wrote:
> On Wed, Jun 28, 2017 at 11:30 PM, Simon Horman
> <simon.horman@...ronome.com> wrote:
> > From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
> >
> > Previously there was no way of updating flow rule stats after they
> > have been offloaded to hardware. This is solved by keeping track of
> > stats received from hardware and providing this to the TC handler
> > on request.
> 
> 
> You are using the term/variable "unmasked_data" across the code, to
> make it clear
> the keys provided to the driver are masked by the tcflower kernel code
> [1] - what do
> you mean by unmasked data?
> 
> Or.
> 
> [1] f93bd17 net/sched: cls_flower: Use masked key when calling HW offloads

>From a firmware point of view there is an unmasked key and a mask.
These are referred to as unmasked_data and mask_data although in
TC supplies a masked key which the firmware can also handle.