netdev - Re: [PATCH v3] datapath: Avoid using stack larger than 1024.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 30 Jun 2017 12:38:55 +0800
From:   Tonghao Zhang <xiangxia.m.yue@...il.com>
To:     Pravin Shelar <pshelar@....org>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Greg Rose <gvrose8192@...il.com>
Subject: Re: [PATCH v3] datapath: Avoid using stack larger than 1024.

Thanks for your works. I send v3 for net-next and add "Acked-by".
If it is applied, I will backport it to dev@...nvswitch.org.

On Fri, Jun 30, 2017 at 1:45 AM, Pravin Shelar <pshelar@....org> wrote:
> On Wed, Jun 28, 2017 at 6:38 PM, Tonghao Zhang <xiangxia.m.yue@...il.com> wrote:
>> When compiling OvS-master on 4.4.0-81 kernel,
>> there is a warning:
>>
>>     CC [M]  /root/ovs/datapath/linux/datapath.o
>>     /root/ovs/datapath/linux/datapath.c: In function
>>     'ovs_flow_cmd_set':
>>     /root/ovs/datapath/linux/datapath.c:1221:1: warning:
>>     the frame size of 1040 bytes is larger than 1024 bytes
>>     [-Wframe-larger-than=]
>>
>> This patch factors out match-init and action-copy to avoid
>> "Wframe-larger-than=1024" warning. Because mask is only
>> used to get actions, we new a function to save some
>> stack space.
>>
>> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>
>> ---
> Looks good, you have to submit patch against net-next for upstream OVS
> module first.