netdev - Re: [PATCH net-next v3] datapath: Avoid using stack larger than 1024.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 01 Jul 2017 09:10:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiangxia.m.yue@...il.com
Cc:     netdev@...r.kernel.org, pshelar@....org, gvrose8192@...il.com
Subject: Re: [PATCH net-next v3] datapath: Avoid using stack larger than
 1024.

From: nickcooper-zhangtonghao <xiangxia.m.yue@...il.com>
Date: Thu, 29 Jun 2017 17:27:44 -0700

> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> 
> When compiling OvS-master on 4.4.0-81 kernel,
> there is a warning:
> 
>     CC [M]  /root/ovs/datapath/linux/datapath.o
>     /root/ovs/datapath/linux/datapath.c: In function
>     'ovs_flow_cmd_set':
>     /root/ovs/datapath/linux/datapath.c:1221:1: warning:
>     the frame size of 1040 bytes is larger than 1024 bytes
>     [-Wframe-larger-than=]
> 
> This patch factors out match-init and action-copy to avoid
> "Wframe-larger-than=1024" warning. Because mask is only
> used to get actions, we new a function to save some
> stack space.
> 
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>
> Acked-by: Pravin B Shelar <pshelar@....org>

Applied.