lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sun, 2 Jul 2017 11:29:25 +0800
From:   kbuild test robot <fengguang.wu@...el.com>
To:     "Reshetova, Elena" <elena.reshetova@...el.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        Hans Liljestrand <ishkamiel@...il.com>,
        Kees Cook <keescook@...omium.org>,
        David Windsor <dave@...lcore.net>
Subject: [net-next:master 1847/1910] drivers/s390/net/ctcm_fsms.c:220:14:
 error: passing argument 2 of 'atomic_add' from incompatible pointer type

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   bcdb239b456265b927a809c4078f0a1f433a6e18
commit: 633547973ffc32fd2c815639d4675e1531f0896f [1847/1910] net: convert sk_buff.users from atomic_t to refcount_t
config: s390-default_defconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 633547973ffc32fd2c815639d4675e1531f0896f
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All errors (new ones prefixed by >>):

   In file included from include/linux/atomic.h:4:0,
                    from include/linux/debug_locks.h:5,
                    from include/linux/lockdep.h:25,
                    from include/linux/spinlock_types.h:18,
                    from include/linux/spinlock.h:81,
                    from include/linux/seqlock.h:35,
                    from include/linux/time.h:5,
                    from include/linux/stat.h:18,
                    from include/linux/module.h:10,
                    from drivers/s390/net/ctcm_fsms.c:17:
   drivers/s390/net/ctcm_fsms.c: In function 'ctcm_purge_skb_queue':
>> drivers/s390/net/ctcm_fsms.c:220:14: error: passing argument 2 of 'atomic_add' from incompatible pointer type [-Werror=incompatible-pointer-types]
      atomic_dec(&skb->users);
                 ^
   arch/s390/include/asm/atomic.h:61:52: note: in definition of macro 'atomic_sub'
    #define atomic_sub(_i, _v)  atomic_add(-(int)(_i), _v)
                                                       ^~
   drivers/s390/net/ctcm_fsms.c:220:3: note: in expansion of macro 'atomic_dec'
      atomic_dec(&skb->users);
      ^~~~~~~~~~
   arch/s390/include/asm/atomic.h:46:20: note: expected 'atomic_t * {aka struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
    static inline void atomic_add(int i, atomic_t *v)
                       ^~~~~~~~~~
   drivers/s390/net/ctcm_fsms.c: In function 'chx_txdone':
   drivers/s390/net/ctcm_fsms.c:274:14: error: passing argument 2 of 'atomic_add' from incompatible pointer type [-Werror=incompatible-pointer-types]
      atomic_dec(&skb->users);
                 ^
   arch/s390/include/asm/atomic.h:61:52: note: in definition of macro 'atomic_sub'
    #define atomic_sub(_i, _v)  atomic_add(-(int)(_i), _v)
                                                       ^~
   drivers/s390/net/ctcm_fsms.c:274:3: note: in expansion of macro 'atomic_dec'
      atomic_dec(&skb->users);
      ^~~~~~~~~~
   arch/s390/include/asm/atomic.h:46:20: note: expected 'atomic_t * {aka struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
    static inline void atomic_add(int i, atomic_t *v)
                       ^~~~~~~~~~
   drivers/s390/net/ctcm_fsms.c:300:15: error: passing argument 2 of 'atomic_add' from incompatible pointer type [-Werror=incompatible-pointer-types]
       atomic_dec(&skb->users);
                  ^
   arch/s390/include/asm/atomic.h:61:52: note: in definition of macro 'atomic_sub'
    #define atomic_sub(_i, _v)  atomic_add(-(int)(_i), _v)
                                                       ^~
   drivers/s390/net/ctcm_fsms.c:300:4: note: in expansion of macro 'atomic_dec'
       atomic_dec(&skb->users);
       ^~~~~~~~~~
   arch/s390/include/asm/atomic.h:46:20: note: expected 'atomic_t * {aka struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
    static inline void atomic_add(int i, atomic_t *v)
                       ^~~~~~~~~~
   drivers/s390/net/ctcm_fsms.c: In function 'ctcmpc_chx_txdone':
   drivers/s390/net/ctcm_fsms.c:1251:14: error: passing argument 2 of 'atomic_add' from incompatible pointer type [-Werror=incompatible-pointer-types]
      atomic_dec(&skb->users);
                 ^
   arch/s390/include/asm/atomic.h:61:52: note: in definition of macro 'atomic_sub'
    #define atomic_sub(_i, _v)  atomic_add(-(int)(_i), _v)
                                                       ^~
   drivers/s390/net/ctcm_fsms.c:1251:3: note: in expansion of macro 'atomic_dec'
      atomic_dec(&skb->users);
      ^~~~~~~~~~
   arch/s390/include/asm/atomic.h:46:20: note: expected 'atomic_t * {aka struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
    static inline void atomic_add(int i, atomic_t *v)
                       ^~~~~~~~~~
   drivers/s390/net/ctcm_fsms.c:1301:14: error: passing argument 2 of 'atomic_add' from incompatible pointer type [-Werror=incompatible-pointer-types]
      atomic_dec(&skb->users);
                 ^
   arch/s390/include/asm/atomic.h:61:52: note: in definition of macro 'atomic_sub'
    #define atomic_sub(_i, _v)  atomic_add(-(int)(_i), _v)
                                                       ^~
   drivers/s390/net/ctcm_fsms.c:1301:3: note: in expansion of macro 'atomic_dec'
      atomic_dec(&skb->users);
      ^~~~~~~~~~
   arch/s390/include/asm/atomic.h:46:20: note: expected 'atomic_t * {aka struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
    static inline void atomic_add(int i, atomic_t *v)
                       ^~~~~~~~~~
   drivers/s390/net/ctcm_fsms.c: In function 'ctcmpc_chx_send_sweep':
   drivers/s390/net/ctcm_fsms.c:1798:14: error: passing argument 2 of 'atomic_add' from incompatible pointer type [-Werror=incompatible-pointer-types]
      atomic_inc(&skb->users);
                 ^
   arch/s390/include/asm/atomic.h:58:40: note: in definition of macro 'atomic_inc'
    #define atomic_inc(_v)   atomic_add(1, _v)
                                           ^~
   arch/s390/include/asm/atomic.h:46:20: note: expected 'atomic_t * {aka struct <anonymous> *}' but argument is of type 'refcount_t * {aka struct refcount_struct *}'
    static inline void atomic_add(int i, atomic_t *v)
                       ^~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/atomic_add +220 drivers/s390/net/ctcm_fsms.c

293d984f Peter Tiedemann 2008-02-08  214  {
293d984f Peter Tiedemann 2008-02-08  215  	struct sk_buff *skb;
293d984f Peter Tiedemann 2008-02-08  216  
aa3f2cb6 Peter Tiedemann 2008-07-18  217  	CTCM_DBF_TEXT(TRACE, CTC_DBF_DEBUG, __func__);
293d984f Peter Tiedemann 2008-02-08  218  
293d984f Peter Tiedemann 2008-02-08  219  	while ((skb = skb_dequeue(q))) {
293d984f Peter Tiedemann 2008-02-08 @220  		atomic_dec(&skb->users);
293d984f Peter Tiedemann 2008-02-08  221  		dev_kfree_skb_any(skb);
293d984f Peter Tiedemann 2008-02-08  222  	}
293d984f Peter Tiedemann 2008-02-08  223  }

:::::: The code at line 220 was first introduced by commit
:::::: 293d984f0e3604c04dcdbf00117ddc1e5d4b1909 ctcm: infrastructure for replaced ctc driver

:::::: TO: Peter Tiedemann <ptiedem@...ibm.com>
:::::: CC: Jeff Garzik <jeff@...zik.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (17250 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ