netdev - Re: [PATCH net-next V2] bpf: fix return in load_bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 05 Jul 2017 09:05:46 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     brakmo@...com
Cc:     netdev@...r.kernel.org, kernel-team@...com, ast@...com,
        daniel@...earbox.net
Subject: Re: [PATCH net-next V2] bpf: fix return in load_bpf_file

From: Lawrence Brakmo <brakmo@...com>
Date: Tue, 4 Jul 2017 15:57:50 -0700

> The function load_bpf_file ignores the return value of
> load_and_attach(), so even if load_and_attach() returns an error,
> load_bpf_file() will return 0.
> 
> Now, load_bpf_file() can call load_and_attach() multiple times and some
> can succeed and some could fail. I think the correct behavor is to
> return error on the first failed load_and_attach().
> 
> v2: Added missing SOB
> 
> Signed-off-by: Lawrence Brakmo <brakmo@...com>

Applied.