netdev - Re: [PATCH net-next RFC 04/12] net: dsa: Add ordered workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 06 Jul 2017 14:45:01 -0400
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Arkadi Sharshevsky <arkadis@...lanox.com>,
        netdev@...r.kernel.org
Cc:     davem@...emloft.net, jiri@...nulli.us, ivecera@...hat.com,
        andrew@...n.ch, Woojung.Huh@...rochip.com,
        stephen@...workplumber.org, mlxsw@...lanox.com
Subject: Re: [PATCH net-next RFC 04/12] net: dsa: Add ordered workqueue

Hi Arkadi,

Florian Fainelli <f.fainelli@...il.com> writes:

> On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote:
>> This workqueue will be used for FDB add/del processing. It should
>> be destroyed after all devices unregistered successfully.
>> 
>> Signed-off-by: Arkadi Sharshevsky <arkadis@...lanox.com>
>> ---
>>  include/net/dsa.h |  1 +
>>  net/dsa/dsa.c     | 13 +++++++++++++
>>  2 files changed, 14 insertions(+)
>> 
>> diff --git a/include/net/dsa.h b/include/net/dsa.h
>> index f054d41..4835b0e 100644
>> --- a/include/net/dsa.h
>> +++ b/include/net/dsa.h
>> @@ -451,6 +451,7 @@ void unregister_switch_driver(struct dsa_switch_driver *type);
>>  struct mii_bus *dsa_host_dev_to_mii_bus(struct device *dev);
>>  
>>  struct net_device *dsa_dev_to_net_device(struct device *dev);
>> +bool dsa_schedule_work(struct work_struct *work);
>
> I'd move this to dsa_priv.h in net/dsa/ because it is not supposed to be
> used by DSA drivers.
>
> You may also consider squashing this into the next patch since in itself
> it's not used just yet.

I agree with Florian on this. Even though it'll make the next patch a
bit bigger, it'll make it easier to understand the whole workqueue
processing logic.

Thanks,

        Vivien