netdev - [PATCH] net: usb: qmi_wwan: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 10 Jul 2017 13:19:07 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     bjorn@...k.no, davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] net: usb: qmi_wwan: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/netdevice.h> work
with const attribute_group. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  16831	    464	      0	  17295	   438f	drivers/net/usb/qmi_wwan.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  16895	    400	      0	  17295	   438f	drivers/net/usb/qmi_wwan.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
---
 drivers/net/usb/qmi_wwan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 5894e3c..b2ddd5c 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -434,7 +434,7 @@ static ssize_t del_mux_store(struct device *d,  struct device_attribute *attr, c
 	NULL,
 };
 
-static struct attribute_group qmi_wwan_sysfs_attr_group = {
+static const struct attribute_group qmi_wwan_sysfs_attr_group = {
 	.name = "qmi",
 	.attrs = qmi_wwan_sysfs_attrs,
 };
-- 
1.9.1