netdev - RE: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Jul 2017 08:20:59 +0000
From:   Biju Das <biju.das@...renesas.com>
To:     Rob Herring <robh@...nel.org>
CC:     Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Simon Horman <horms@...ge.net.au>,
        Magnus Damm <magnus.damm@...il.com>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH v 1/2] ravb: Add support for r8a7743 SoC

Hello,

Thanks for the review.

> -----Original Message-----
> From: Rob Herring [mailto:robh@...nel.org]
> Sent: 10 July 2017 02:20
> To: Biju Das <biju.das@...renesas.com>
> Cc: Mark Rutland <mark.rutland@....com>; Russell King
> <linux@...linux.org.uk>; Sergei Shtylyov
> <sergei.shtylyov@...entembedded.com>; Simon Horman
> <horms@...ge.net.au>; Magnus Damm <magnus.damm@...il.com>; Chris
> Paterson <Chris.Paterson2@...esas.com>; devicetree@...r.kernel.org; linux-
> renesas-soc@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> netdev@...r.kernel.org
> Subject: Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC
>
> On Wed, Jul 05, 2017 at 02:01:50PM +0100, Biju Das wrote:
> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC.
> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car
> > Gen2 family.
>
> For the subject: "dt-bindings: net: ..."

I will change the subject to "dt-bindings: net: ravb: ..

>
> >
> > Signed-off-by: Biju Das <biju.das@...renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@...esas.com>
> > ---
> >  Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++-
> >  drivers/net/ethernet/renesas/ravb_main.c               | 1 +
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > index b519503..bc692ab 100644
> > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > @@ -4,7 +4,8 @@ This file provides information on what the device node
> > for the Ethernet AVB  interface contains.
> >
> >  Required properties:
> > -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790
> SoC.
> > +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743
> SoC.
> > +      "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>
> Please re-format like this:
>
> - compatible: Must be one of:
> ...
>
Ok. I will change this as well.

> So it's a one line change to add new compatibles.
>
> >        "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> >        "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> >        "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> > diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> > b/drivers/net/ethernet/renesas/ravb_main.c
> > index 5931e85..e35b30f 100644
> > --- a/drivers/net/ethernet/renesas/ravb_main.c
> > +++ b/drivers/net/ethernet/renesas/ravb_main.c
> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private
> > *priv)  }
> >
> >  static const struct of_device_id ravb_match_table[] = {
> > +{ .compatible = "renesas,etheravb-r8a7743", .data = (void
> > +*)RCAR_GEN2 },
> >  { .compatible = "renesas,etheravb-r8a7790", .data = (void
> *)RCAR_GEN2 },
> >  { .compatible = "renesas,etheravb-r8a7794", .data = (void
> *)RCAR_GEN2 },
> >  { .compatible = "renesas,etheravb-rcar-gen2", .data = (void
> > *)RCAR_GEN2 },
> > --
> > 1.9.1
> >



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.