lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Jul 2017 11:48:06 +0200 From: Richard Cochran <richardcochran@...il.com> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Ganesh Goudar <ganeshgr@...lsio.com>, Atul Gupta <atul.gupta@...lsio.com>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 1/2 net] ptp: fix error codes in ptp_clock_register() On Mon, Jul 10, 2017 at 12:38:16PM +0300, Dan Carpenter wrote: > There were two buggy commits so I chose the ealier one. The other buggy No, you are mistaken. In the original patch, NULL or PTR_ERR were returned on error, and that was not a bug. If you want to correct the present version of ptp_clock_register() to always return a valid pointer or PTR_ERR (like the kerneldoc says), be my guest, but please say that in the change log and reference the correct commit (namely the one related to disabling POSIX clocks.) Thanks, Richard
Powered by blists - more mailing lists