netdev - Re: [PATCH net-next] inetpeer: remove AVL implementation in favor of RB tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Jul 2017 08:59:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     pablo@...filter.org, fw@...len.de, netfilter-devel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] inetpeer: remove AVL implementation in favor
 of RB tree

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 17 Jul 2017 02:56:10 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> As discussed in Faro during Netfilter Workshop 2017, RB trees can be
> used with RCU, using a seqlock.
> 
> Note that net/rxrpc/conn_service.c is already using this.
> 
> This patch converts inetpeer from AVL tree to RB tree, since it allows
> to remove private AVL implementation in favor of shared RB code.
> 
> $ size net/ipv4/inetpeer.before net/ipv4/inetpeer.after
>    text    data     bss     dec     hex filename
>    3195      40     128    3363     d23 net/ipv4/inetpeer.before
>    1562      24       0    1586     632 net/ipv4/inetpeer.after
> 
> The same technique can be used to speed up
> net/netfilter/nft_set_rbtree.c (removing rwlock contention in fast path)
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks for doing this Eric.