netdev - Re: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2017 16:02:39 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Fabio Estevam <fabio.estevam@....com>
Subject: Re: [PATCH net-next] mdio_bus: Remove unneeded gpiod NULL check

On 07/18/2017 03:52 PM, Fabio Estevam wrote:

>>>>    Won't this result in kernel WARNING when GPIO is disabled?
>>
>>
>>    GPIO support, I was going to type...
>>
>>> Not sure if I understood your point, but gpiod_set_value_cansleep() is
>>> a no-op when the gpiod is NULL.
>>
>>
>>    Look at the stub in <linux/gpio/consumer.h>, it has WARN_ON(1).
>
> This patch does not alter the behavior of the driver with respect to
> GPIO being disabled,

    No, it does -- devm_gpiod_get_optinal() will return NULL in that case, 
bus->reset_gpio will remanin NULL, and you're removing the NULL checks around 
the gpiod_set_value_cansleep() calls. Perhaps it's the problem in the GPIO 
support though...

> so I still do not understand your concern.

    And now?

MBR, Sergei