netdev - Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Jul 2017 09:43:18 +0200
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     Franklin S Cooper Jr <fcooper@...com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        netdev@...r.kernel.org, linux-can@...r.kernel.org,
        wg@...ndegger.com, mkl@...gutronix.de, robh+dt@...nel.org,
        quentin.schulz@...e-electrons.com, dev.kurt@...dijck-laurijssen.be,
        andrew@...n.ch
Subject: Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

Hi Franklin,

On 07/20/2017 01:36 AM, Franklin S Cooper Jr wrote:

> +#ifdef CONFIG_OF
> +void of_transceiver_is_fixed(struct net_device *dev)
> +{

(..)

> +}
> +EXPORT_SYMBOL(of_transceiver_is_fixed);
> +#endif

I'm not sure about the naming here.

As this is a CAN transceiver related option it should be named accordingly:

E.g.

	can_transceiver_is_fixed
	of_can_transceiver_is_fixed
	...

Especially as it is defined in include/linux/can/dev.h

Regards,
Oliver