netdev - Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Jul 2017 11:13:57 +0100
From:   kiki good <jqiaoulk@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics

Hi David:

I am sorry for missing the commit log message;Since I did conversation
with Florian Fainelli about this patch in another email thread
"[PATCH] net: systemport: Support 64bit statistics", i incorrectly
thought it was unnecessary to add the commit log again when submitting
the revised patch.

The reason for keeping both  .ndo_get_stats and 64-bit
.ndo_get_stats64 comes from Florian, suggesting that because there is
no harm in keeping bcm_sysport_get_stats and we can always deprecate
it later, it is just to minimize the amount of changes to review.

Why do we need this change ?
When using Broadcom Systemport device in 32bit Platform, ifconfig can
only report up to 4G tx,rx status, which will be wrapped to 0 when the
number of incoming or outgoing packets exceeds 4G, only taking
around 2 hours in busy network environment (such as streaming).
Therefore, it makes hard for network diagnostic tool to get reliable
statistical result, so the patch is used to add 64bit support for
Broadcom Systemport device in 32bit Platform.

Thanks
Jmqiao

On Thu, Jul 20, 2017 at 6:25 AM, David Miller <davem@...emloft.net> wrote:
> From: "Jianming.qiao" <jqiaoulk@...il.com>
> Date: Wed, 19 Jul 2017 01:18:40 +0100
>
>> Signed-off-by: Jianming.qiao <kiki-good@...mail.com>
>
> Supporting both deprecated .ndo_get_stats and 64-bit .ndo_get_stats64
> at the same time makes no sense.
>
> .ndo_get_stats will never be called if .ndo_get_stats64 is non-NULL
>
> The lack of a commit log message, explaining in detail, why you are
> doing this and why you are doing it this way, concerns me as well.
>
> This submission so far has been a bit of a mess.  You don't
> communicate enough, your commit message is empty, and therefore we
> have no idea why you are doing things, and in particular the reasons
> for your decisions.
>
> I'm not applying this, sorry.