netdev - Re: [PATCH net-next 2/8] netvsc: add some rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Jul 2017 17:52:44 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     kbuild-all@...org, kys@...rosoft.com, haiyangz@...rosoft.com,
        sthemmin@...rosoft.com, devel@...uxdriverproject.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/8] netvsc: add some rtnl_dereference
 annotations

Hi Stephen,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Stephen-Hemminger/netvsc-lockdep-and-related-fixes/20170720-191938
config: x86_64-rhel (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the linux-review/Stephen-Hemminger/netvsc-lockdep-and-related-fixes/20170720-191938 HEAD a5e48342eae178e9ed020d3634cdf92f1f05cb70 builds fine.
      It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

   drivers/net/hyperv/netvsc.c: In function 'netvsc_switch_datapath':
>> drivers/net/hyperv/netvsc.c:44:33: error: implicit declaration of function 'rtnl_dereference' [-Werror=implicit-function-declaration]
     struct netvsc_device *nv_dev = rtnl_dereference(net_device_ctx->nvdev);
                                    ^~~~~~~~~~~~~~~~
>> drivers/net/hyperv/netvsc.c:44:33: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
   drivers/net/hyperv/netvsc.c: In function 'netvsc_device_remove':
   drivers/net/hyperv/netvsc.c:553:5: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
      = rtnl_dereference(net_device_ctx->nvdev);
        ^~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/rtnl_dereference +44 drivers/net/hyperv/netvsc.c

    35	
    36	/*
    37	 * Switch the data path from the synthetic interface to the VF
    38	 * interface.
    39	 */
    40	void netvsc_switch_datapath(struct net_device *ndev, bool vf)
    41	{
    42		struct net_device_context *net_device_ctx = netdev_priv(ndev);
    43		struct hv_device *dev = net_device_ctx->device_ctx;
  > 44		struct netvsc_device *nv_dev = rtnl_dereference(net_device_ctx->nvdev);
    45		struct nvsp_message *init_pkt = &nv_dev->channel_init_pkt;
    46	
    47		memset(init_pkt, 0, sizeof(struct nvsp_message));
    48		init_pkt->hdr.msg_type = NVSP_MSG4_TYPE_SWITCH_DATA_PATH;
    49		if (vf)
    50			init_pkt->msg.v4_msg.active_dp.active_datapath =
    51				NVSP_DATAPATH_VF;
    52		else
    53			init_pkt->msg.v4_msg.active_dp.active_datapath =
    54				NVSP_DATAPATH_SYNTHETIC;
    55	
    56		vmbus_sendpacket(dev->channel, init_pkt,
    57				       sizeof(struct nvsp_message),
    58				       (unsigned long)init_pkt,
    59				       VM_PKT_DATA_INBAND, 0);
    60	
    61		net_device_ctx->datapath = vf;
    62	}
    63	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (39495 bytes)