netdev - Re: [PATCH] of_mdio: kill useless variable in of_phy_register_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Jul 2017 16:28:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sergei.shtylyov@...entembedded.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, robh+dt@...nel.org,
        frowand.list@...il.com, netdev@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] of_mdio: kill useless variable in
 of_phy_register_fixed_link()

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Sun, 23 Jul 2017 21:45:47 +0300

> of_phy_register_fixed_link() declares the 'err' variable to hold the result
> of of_property_read_string() but only uses it once after that, while that
> function can be called directly from the *if* statement...
> 
> Remove that variable and move/regroup 'link_gpio' and 'len' variables in
> order to sort the declarations in the reverse Xmas tree order -- to please
> DaveM. ;-)

Respect MY AUTHORITY! :-)

> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

Applied, thanks.