netdev - Re: [Patch net] bonding: commit link status change after propose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Jul 2017 15:14:35 -0700
From:   Mahesh Bandewar (महेश बंडेवार) 
        <maheshb@...gle.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     linux-netdev <netdev@...r.kernel.org>, benjamin.gilbert@...eos.com
Subject: Re: [Patch net] bonding: commit link status change after propose

On Tue, Jul 25, 2017 at 9:44 AM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> Commit de77ecd4ef02 ("bonding: improve link-status update in mii-monitoring")
> moves link status commitment into bond_mii_monitor(), but it still relies
> on the return value of bond_miimon_inspect() as the hint. We need to return
> non-zero as long as we propose a link status change.
>
> Fixes: de77ecd4ef02 ("bonding: improve link-status update in mii-monitoring")
> Reported-by: Benjamin Gilbert <benjamin.gilbert@...eos.com>
> Tested-by: Benjamin Gilbert <benjamin.gilbert@...eos.com>
> Cc: Mahesh Bandewar <maheshb@...gle.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
Acked-by: Mahesh Bandewar <maheshb@...gle.com>
> ---
>  drivers/net/bonding/bond_main.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 181839d6fbea..9bee6c1c70cc 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -2050,6 +2050,7 @@ static int bond_miimon_inspect(struct bonding *bond)
>                                 continue;
>
>                         bond_propose_link_state(slave, BOND_LINK_FAIL);
> +                       commit++;
>                         slave->delay = bond->params.downdelay;
>                         if (slave->delay) {
>                                 netdev_info(bond->dev, "link status down for %sinterface %s, disabling it in %d ms\n",
> @@ -2088,6 +2089,7 @@ static int bond_miimon_inspect(struct bonding *bond)
>                                 continue;
>
>                         bond_propose_link_state(slave, BOND_LINK_BACK);
> +                       commit++;
>                         slave->delay = bond->params.updelay;
>
>                         if (slave->delay) {
> --
> 2.13.0
>