lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Jul 2017 12:59:44 +0200 From: Egil Hjelmeland <privat@...l-hjelmeland.no> To: Andrew Lunn <andrew@...n.ch> Cc: corbet@....net, vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com, davem@...emloft.net, kernel@...gutronix.de, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH net-next v2 06/10] net: dsa: lan9303: added sysfs node swe_bcst_throt On 26. juli 2017 19:14, Andrew Lunn wrote: > On Tue, Jul 25, 2017 at 06:15:49PM +0200, Egil Hjelmeland wrote: >> Allowing per-port access to Switch Engine Broadcast Throttling Register > > Hi Egil > > In general, we are against using sysfs. If there is a generic > mechanism, that applies for all sorts of network interfaces, it should > be used instead of sysfs. > > Is this intended to reduce the effect of broadcast storms? > > Andrew > Yes, this setting can be used to reduce effect of broadcast storms. I knew you all dislike using sysfs. Still I had a hope you could accept the dsa_net_device_to_dsa_port() function it the previous patch. I feel it would be convenient to be able to add driver sysfs nodes in private branches for own debug and fine tuning, without having to patch the networking core. Egil
Powered by blists - more mailing lists