netdev - Re: mwifiex: fix compile warning of unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2017 14:50:02 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Shawn Lin <shawn.lin@...k-chips.com>
Cc:     Amitkumar Karwar <amitkarwar@...il.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        Nishant Sarmukadam <nishants@...vell.com>,
        Xinming Hu <huxm@...vell.com>,
        Shawn Lin <shawn.lin@...k-chips.com>
Subject: Re: mwifiex: fix compile warning of unused variable

Shawn Lin <shawn.lin@...k-chips.com> wrote:

> We got a compile warning shows below:
> 
> drivers/net/wireless/marvell/mwifiex/sdio.c: In function
> 'mwifiex_sdio_remove':
> drivers/net/wireless/marvell/mwifiex/sdio.c:377:6: warning: variable
> 'ret' set but not used [-Wunused-but-set-variable]
> 
> Per the code, it didn't check if mwifiex_sdio_read_fw_status
> finish successfully. We should at least check the return of
> mwifiex_sdio_read_fw_status, otherwise the following check of
> firmware_stat and adapter->mfg_mode is pointless as the device
> is probably dead.
> 
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
> Reviewed-by: Brian Norris <briannorris@...omium.org>

Patch applied to wireless-drivers-next.git, thanks.

f46a5b0156b1 mwifiex: fix compile warning of unused variable

-- 
https://patchwork.kernel.org/patch/9827585/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches