netdev - Re: [RFC] switchdev: generate phys_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2017 16:13:40 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     Or Gerlitz <gerlitz.or@...il.com>, Jiri Pirko <jiri@...nulli.us>,
        netdev@...r.kernel.org, Or Gerlitz <ogerlitz@...lanox.com>,
        Michael Chan <michael.chan@...adcom.com>,
        Sathya Perla <sathya.perla@...adcom.com>,
        David Miller <davem@...emloft.net>, simon.horman@...ronome.com
Subject: Re: [RFC] switchdev: generate phys_port_name in the core

On Thu, Jul 27, 2017 at 07:31:22PM -0700, Jakub Kicinski wrote:
> On Thu, 27 Jul 2017 13:30:44 +0300, Or Gerlitz wrote:
> > > want to add port splitting support, for example, reporting the name on
> > > physical ports will become more of a necessity.  
> > 
> > > If we adopt Jiri's suggestion of returning structured data it will be
> > > very easy to give user space type and indexes separately, but we should
> > > probably still return the string for backwards compatibility.  
> > 
> > I am not still clear how the structured data would look like
> 
> I decided to just quickly write the code, that should be easier to 
> understand.  We can probably leave out the netlink part of the API
> if there is no need for it right now, but that's what I ment by
> returning the information in a more structured way.
> 
> Tested-by: nobody :)
> Suggested-by: Jiri (if I understood correctly)
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_rep.c |  8 ++-
>  drivers/net/ethernet/mellanox/mlxsw/switchx2.c   | 10 ++--
>  drivers/net/ethernet/netronome/nfp/nfp_port.c    | 26 ++++-----
>  drivers/net/ethernet/netronome/nfp/nfp_port.h    |  4 +-
>  include/linux/netdevice.h                        | 18 ++++++-
>  include/uapi/linux/if_link.h                     | 16 ++++++
>  net/core/dev.c                                   | 31 +++++++++--
>  net/core/rtnetlink.c                             | 69 ++++++++++++++++++++++++

Hi Jakub

Don't forget net/dsa/slave.c when you go from RFC to a real patch for
submission.

	Andrew