netdev - Re: [RFC PATCH v1 2/5] tcp: Implemented the timing-based operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2017 18:46:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     natale.patriciello@...il.com
Cc:     kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
        kaber@...sh.net, netdev@...r.kernel.org, ahmed.said@...roma2.it,
        zampognaro@....uniroma2.it, roseti@....uniroma2.it
Subject: Re: [RFC PATCH v1 2/5] tcp: Implemented the timing-based operations

From: Natale Patriciello <natale.patriciello@...il.com>
Date: Fri, 28 Jul 2017 21:59:16 +0200

> @@ -369,6 +369,9 @@ struct tcp_sock {
>  	 */
>  	struct request_sock *fastopen_rsk;
>  	u32	*saved_syn;
> +
> +/* TCP send timer */
> +	struct timer_list send_timer;
>  };
>  
>  enum tsq_enum {

If this is congestion control specific it should go into the congestion
control algorithm metadata.  If not, then it's OK to be here I guess :)

> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index 4858e190f6ac..357b9cd5019e 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -2187,6 +2187,7 @@ static bool tcp_write_xmit(struct sock *sk, unsigned int mss_now, int nonagle,
>  			   int push_one, gfp_t gfp)
>  {
>  	struct tcp_sock *tp = tcp_sk(sk);
> +	const struct tcp_congestion_ops *ca_ops;
>  	struct sk_buff *skb;
>  	unsigned int tso_segs, sent_pkts;
>  	int cwnd_quota;

Please maintain the reverse christmas tree (longest to shortest) line ordering
of all local variable declarations.

> +	if (timer_pending(&tp->send_timer) == 0) {
> +		/* Timer is not running, push data out */
> +		int ret;
> +		const struct tcp_congestion_ops *ca_ops;

Likewise.