netdev - RE: [PATCH V3 net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Jul 2017 03:29:20 +0000
From:   maowenan <maowenan@...wei.com>
To:     Neal Cardwell <ncardwell@...gle.com>
CC:     Netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Yuchung Cheng <ycheng@...gle.com>,
        Nandita Dukkipati <nanditad@...gle.com>,
        "weiyongjun (A)" <weiyongjun1@...wei.com>,
        Chenweilong <chenweilong@...wei.com>,
        "Wangkefeng (Kevin)" <wangkefeng.wang@...wei.com>
Subject: RE: [PATCH V3 net-next] TLP: Don't reschedule PTO when there's one
 outstanding TLP retransmission



> -----Original Message-----
> From: Neal Cardwell [mailto:ncardwell@...gle.com]
> Sent: Saturday, July 29, 2017 10:04 PM
> To: maowenan
> Cc: Netdev; David Miller; Yuchung Cheng; Nandita Dukkipati; weiyongjun (A);
> Chenweilong; Wangkefeng (Kevin)
> Subject: Re: [PATCH V3 net-next] TLP: Don't reschedule PTO when there's one
> outstanding TLP retransmission
> 
> On Fri, Jul 28, 2017 at 9:39 PM, maowenan <maowenan@...wei.com> wrote:
> > [Mao Wenan]ok, We have reproduced this issue with packetdrill
> > yesterday, there is no the same issue when TLP send new data packet,
> > RTO will be fired and retransmit packet.
> 
> That's great to hear that you were able to reproduce this with packetdrill.
> Would you be able to share the packetdrill scripts that reproduce your issues? I
> would like to make sure our proposed patch addresses your scenarios as well.
[Mao Wenan]please refer to the attachment, test.pkt is packetdrill script. 
In test.pcap, packet number 17 is the TLP probe, packet number 218 is the
retransmission packet because client don't send data packet to server. 
From the capture time, there are about 6 seconds the retransmission
packet can be sent, and this time can be added more as long as client 
send data packet continually.
I have reproduced this issue in Linux 4.13-rc3, 3.10, 4.1. Please check the timing 
When you use test.pkt to reproduce in your environment.
> 
> thanks,
> neal

Download attachment "test.pcap" of type "application/octet-stream" (135408 bytes)

Download attachment "test.pkt" of type "application/octet-stream" (9892 bytes)